Skip to content

chore(zookeeper): Speed up build by removing unnecessary steps #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

chore(zookeeper): Speed up build by removing unnecessary steps #1324

merged 1 commit into from
Oct 31, 2025

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Oct 30, 2025 •
edited
Loading

I believe the build is now quicker than it was.

This was discussed in a slack thread.

--- PASS: kuttl (912.71s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/delete-rolegroup_zookeeper-3.9.3,oci.stackable.tech_sandbox_nick_zookeeper_3.9.3-stackable0.0.0-dev-amd64_openshift-false (42.03s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3,oci.stackable.tech_sandbox_nick_zookeeper_3.9.3-stackable0.0.0-dev-amd64_use-server-tls-true_use-client-auth-tls-true_openshift-false (104.47s)
        --- PASS: kuttl/harness/logging_zookeeper-3.9.4,oci.stackable.tech_sandbox_nick_zookeeper_3.9.4-stackable0.0.0-dev-amd64_openshift-false (68.15s)
        --- PASS: kuttl/harness/logging_zookeeper-3.9.3,oci.stackable.tech_sandbox_nick_zookeeper_3.9.3-stackable0.0.0-dev-amd64_openshift-false (64.91s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.4,oci.stackable.tech_sandbox_nick_zookeeper_3.9.4-stackable0.0.0-dev-amd64_use-server-tls-true_use-client-auth-tls-true_openshift-false (78.96s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.4,oci.stackable.tech_sandbox_nick_zookeeper_3.9.4-stackable0.0.0-dev-amd64_use-server-tls-true_use-client-auth-tls-false_openshift-false (74.74s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.4,oci.stackable.tech_sandbox_nick_zookeeper_3.9.4-stackable0.0.0-dev-amd64_use-server-tls-false_use-client-auth-tls-true_openshift-false (78.59s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.4,oci.stackable.tech_sandbox_nick_zookeeper_3.9.4-stackable0.0.0-dev-amd64_use-server-tls-false_use-client-auth-tls-false_openshift-false (78.94s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3,oci.stackable.tech_sandbox_nick_zookeeper_3.9.3-stackable0.0.0-dev-amd64_use-server-tls-false_use-client-auth-tls-false_openshift-false (64.65s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3,oci.stackable.tech_sandbox_nick_zookeeper_3.9.3-stackable0.0.0-dev-amd64_use-server-tls-true_use-client-auth-tls-false_openshift-false (75.10s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.3,oci.stackable.tech_sandbox_nick_zookeeper_3.9.3-stackable0.0.0-dev-amd64_use-server-tls-false_use-client-auth-tls-true_openshift-false (79.02s)
        --- PASS: kuttl/harness/cluster-operation_zookeeper-latest-3.9.4,oci.stackable.tech_sandbox_nick_zookeeper_3.9.4-stackable0.0.0-dev-amd64_openshift-false (29.35s)
        --- PASS: kuttl/harness/znode_zookeeper-latest-3.9.4,oci.stackable.tech_sandbox_nick_zookeeper_3.9.4-stackable0.0.0-dev-amd64_openshift-false (27.51s)
        --- PASS: kuttl/harness/delete-rolegroup_zookeeper-3.9.4,oci.stackable.tech_sandbox_nick_zookeeper_3.9.4-stackable0.0.0-dev-amd64_openshift-false (46.26s)
PASS

@NickLarsenNZ NickLarsenNZ self-assigned this Oct 30, 2025
@NickLarsenNZ NickLarsenNZ moved this to Development: Waiting for Review in Stackable Engineering Oct 30, 2025
@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Oct 30, 2025

Does this need a changelog entry? Nothing should be affected, they were just extra checks during the build.

sbernauer
sbernauer approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as @lfrancke agreed.
I don't think this needs a changelog entry

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Oct 31, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Oct 31, 2025
Merged via the queue into main with commit ca5ac64 Oct 31, 2025
3 checks passed
@NickLarsenNZ NickLarsenNZ deleted the zookeeper-fast-build branch October 31, 2025 06:32
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NickLarsenNZ @sbernauer