-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(superset): Add needed Python libs for OIDC #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Quick question: Is this needed for everyone? |
Yes it's a generic issue mentioned here apache/superset#23443 ( although that's Oauth ) This fixes the exact same problem for OIDC. |
Converted to draft as we want to discuss a bit more about this. To be picked up at some point. |
I think this waits on the decision https://github.com/stackabletech/decisions/issues/21, putting it back to progress |
Further more, this waits on a discussion when @lfrancke is back since it's security relevance. |
…ocker-images into fix/superset-oidc-logout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment with a suggestion, but marked as approved in case my interpretation is wrong.
Co-authored-by: Nick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change required
Co-authored-by: Nick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This adds a custom manager which:
Flask_OIDC
andFlask_openID
to the Docker image if it's product version4.0.2
( needed by fix )Additionally there are going to be changes for the operator stackabletech/superset-operator#530
This is a little more complicated then expected but works the way outlined in
001-superset_logout.patch
.Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.