chore(spark): update versions for 24.11 #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
approved these changes
Sep 12, 2024
NickLarsenNZ
requested changes
Sep 12, 2024
| -Dmaven.javadoc.skip=true \ | ||
| -Dmaven.scaladoc.skip=true \ | ||
| -Dmaven.source.skip \ | ||
| - -Dcyclonedx.skip=true \ |
There was a problem hiding this comment.
Is this because it is broken?
Semi-related, where do we document patches, like the reasoning as to why some things are added/removed? Or is it always to resolve security vulnerabilities?
There was a problem hiding this comment.
The first question is better answered by @dervoeti I guess.
The semi-related question is a good one. Maybe we could handle it here: https://github.com/stackabletech/decisions/issues/26
There was a problem hiding this comment.
Thanks. Will leave this open until @dervoeti responds, just so we have a reason somewhere.
NickLarsenNZ
added a commit
that referenced
this pull request
Sep 12, 2024
This will become useful for whoever does the next update(s).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* fix(issue-templates): repair invalid tasklist * chore(issue-templates): add additional details to templates * fix(spark): use correct url in comment (#848) This will become useful for whoever does the next update(s). * chore(spark): add additional help * chore(issue-templates): Add note in the front-matter about the project not being auto-assigned * chore(issue-templates): rename the pre-release template to early-pre-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
part of #838
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.