Skip to content

Conversation

@lfrancke
Copy link
Member

@lfrancke lfrancke commented Sep 18, 2024

Description

Enable Docker build checks
https://docs.docker.com/build/checks/
A Docker build will now fail if there is a violation against one of the built-in Docker validation rules

I did manually build all images and fixed all validation warnings that popped up. Most were not bad but two were an actual bug (spark & kafka-testing-tools, both not bad)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Add an entry to the CHANGELOG.md file
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

https://docs.docker.com/build/checks/
A Docker build will now fail if there is a violation against one of the built-in Docker validation rules
@lfrancke lfrancke self-assigned this Sep 18, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry.

I also asked elsewhere but can't recall where.. what should we do about the hadolint failures around apt package versioning?
Non-admins won't be able to merge if the errors aren't resolved (I don't think).

We can either add a rule to ignore those checks (so it works as it always has), or pin the versions - which is a bit of work and will constantly need changing.

@lfrancke
Copy link
Member Author

lfrancke commented Oct 1, 2024

Changelog has been added

as to your other question: the pre-commit checks are optional for now, I'd be happy to add a rule ignoring those packaging things for now until we get to it

@lfrancke lfrancke requested a review from NickLarsenNZ October 1, 2024 09:04
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 795f7a6 Oct 1, 2024
1 of 2 checks passed
@lfrancke lfrancke deleted the feat/build-checks branch October 1, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants