Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Sep 23, 2024

Description

part of stackabletech/hbase-operator#508

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@razvan razvan self-assigned this Sep 26, 2024
@razvan razvan marked this pull request as ready for review September 26, 2024 08:45
@razvan razvan requested a review from a team September 26, 2024 08:45
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait with merge until just before merging the operator PR. There might be the case we don't need it

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment

Comment on lines +335 to +337
# TODO: maybe hostname is useful enough to have in stackable-base ?
# hostname is required by the hbase/bin/graceful_stop.sh to identify the actual name
# of the region server that is being shut down.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is useful enough to put in stackable-base.

@razvan
Copy link
Member Author

razvan commented Nov 27, 2024

obsolete. SDP doesn't use the graceful shutdown script.

@razvan razvan closed this Nov 27, 2024
@razvan razvan deleted the hbase/add-hostname branch June 4, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants