Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 2, 2024

Description

Not needed anymore since stackabletech/kafka-operator#443.
We could have removed back than already, but waited for 24.11 explicitly just to be sure.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@nightkr
Copy link
Contributor

nightkr commented Oct 30, 2024

Do we want to document somewhere for 24.11 that this is deprecated?

@sbernauer
Copy link
Member Author

I'm happy to silently remove it, as only kafka-operator should be using it.
I just proposed to wait until the release is over, just in case some customer messes up his env and the product image being more recent than the operator image

@sbernauer sbernauer force-pushed the chore/kafka-remove-kubectl branch from 800969b to eec7db2 Compare December 4, 2024 13:06
@adwk67 adwk67 self-requested a review December 10, 2024 11:59
adwk67
adwk67 previously approved these changes Dec 10, 2024
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(built images locally, verified kubectl is no longer in the images, nightly tests all good).

@sbernauer sbernauer added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit c716fe5 Dec 11, 2024
3 checks passed
@sbernauer sbernauer deleted the chore/kafka-remove-kubectl branch December 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Removed
Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants