-
-
Couldn't load subscription status.
- Fork 6
ci: Use stackabletech/actions repo #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of things to note:
- Maybe hold off on the merge until the end of the day (since it will consume a lot of runners). Or at least let everyone know that it is happening so they can work around it.
- I wonder if Renovate can raise PRs when there is a new commit hash in the actions repo.
Yeah that makes sense. Will do so.
I'm no Renovate expert, so I don't know. Maybe @lfrancke knows more about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I want all new things we merge to be auto updatable. If you're not sure it can be please hold off. I don't have time to look today. |
|
So we can support Renovate by adding tags to the https://github.com/stackabletech/actions repo, according to these supported data sources. I can add an initial tag (e.g. |
I thought Renovate could also do commit hash updates too 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It can update the commit hash, but it needs a git tag to be present. For example: Currently, the tag |
|
Shall we try that next week? |
Sure, we can do that. |
|
Now that I'm affected by it: Was this discussed? I do understand the reason for moving out pre-commit as we might reuse it..but the other stuff: Will we ever reuse this anywhere? Upgrading stuff is now much harder compared to before. Before
After
That would be fine with me if there were any benefit to the change and I don't see one right now. |
|
I just tried to run renovate, but: See the Dependency Dashboard (this might change hence the screenshot & extract) |
|
I'm sure it's documented somewhere and I'm sure it can be configured. If anyone wants to google for it later look for "applyDatasourceFilters (datasource/index.ts)" and "applyExtractVersion" and the "extractVersion" regex in renovate. |
Well, then the following section in the docs is clearly a lie:
It might be worth to fix this upstream then? |

This PR updates all workflows to use the https://github.com/stackabletech/actions repo instead of local actions.