Skip to content

Conversation

@Techassi
Copy link
Member

@Techassi Techassi commented Oct 2, 2024

This PR updates all workflows to use the https://github.com/stackabletech/actions repo instead of local actions.

@Techassi Techassi self-assigned this Oct 2, 2024
@Techassi Techassi marked this pull request as ready for review October 2, 2024 11:37
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 2, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of things to note:

  • Maybe hold off on the merge until the end of the day (since it will consume a lot of runners). Or at least let everyone know that it is happening so they can work around it.
  • I wonder if Renovate can raise PRs when there is a new commit hash in the actions repo.

@Techassi
Copy link
Member Author

Techassi commented Oct 2, 2024

Maybe hold off on the merge until the end of the day (since it will consume a lot of runners). Or at least let everyone know that it is happening so they can work around it.

Yeah that makes sense. Will do so.

I wonder if Renovate can raise PRs when there is a new commit hash in the actions repo.

I'm no Renovate expert, so I don't know. Maybe @lfrancke knows more about it.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 2, 2024
@lfrancke
Copy link
Member

lfrancke commented Oct 2, 2024

I want all new things we merge to be auto updatable. If you're not sure it can be please hold off. I don't have time to look today.

@Techassi
Copy link
Member Author

Techassi commented Oct 2, 2024

So we can support Renovate by adding tags to the https://github.com/stackabletech/actions repo, according to these supported data sources.

I can add an initial tag (e.g. 0.0.1) to enable support right now.

@NickLarsenNZ
Copy link
Member

So we can support Renovate by adding tags to the https://github.com/stackabletech/actions repo, according to these supported data sources.

I can add an initial tag (e.g. 0.0.1) to enable support right now.

I thought Renovate could also do commit hash updates too 🤷

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi
Copy link
Member Author

Techassi commented Oct 2, 2024

So we can support Renovate by adding tags to the stackabletech/actions repo, according to these supported data sources.
I can add an initial tag (e.g. 0.0.1) to enable support right now.

I thought Renovate could also do commit hash updates too 🤷

It can update the commit hash, but it needs a git tag to be present. For example: Currently, the tag 0.0.1 points to 93b2a5a023487ef9509f24600c12374553478f1d. Once we add a new tag 0.0.2 which will for example point to 1234abcd, Renovate will use that commit hash.

@lfrancke
Copy link
Member

lfrancke commented Oct 2, 2024

Shall we try that next week?

@Techassi
Copy link
Member Author

Techassi commented Oct 2, 2024

Shall we try that next week?

Sure, we can do that.

@Techassi Techassi added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 43ffeec Oct 2, 2024
2 checks passed
@Techassi Techassi deleted the ci/use-stackable-actions branch October 2, 2024 14:16
@lfrancke
Copy link
Member

lfrancke commented Oct 2, 2024

Now that I'm affected by it: Was this discussed? I do understand the reason for moving out pre-commit as we might reuse it..but the other stuff: Will we ever reuse this anywhere?

Upgrading stuff is now much harder compared to before.
I'd lean towards a revert for now.
I like the idea in general

Before

  1. Update version number in PR in docker-images

After

  1. Create PR to update things in stackabletech/actions
  2. Tag new build in stackabletech/actions
  3. Create PR in docker-images to update actions

That would be fine with me if there were any benefit to the change and I don't see one right now.

@lfrancke
Copy link
Member

lfrancke commented Oct 4, 2024

I just tried to run renovate, but:

Renovate failed to look up the following dependencies: Can't find version matching 0.0.1 for github-tags package stackabletech/actions,

See the Dependency Dashboard (this might change hence the screenshot & extract)

image

@lfrancke
Copy link
Member

lfrancke commented Oct 4, 2024

I'm sure it's documented somewhere and I'm sure it can be configured.
But: The tag & release need to be prepended with a "v". So it needs to be v0.0.1, v0.0.2

If anyone wants to google for it later look for "applyDatasourceFilters (datasource/index.ts)" and "applyExtractVersion" and the "extractVersion" regex in renovate.

@Techassi
Copy link
Member Author

Techassi commented Oct 7, 2024

I'm sure it's documented somewhere and I'm sure it can be configured.
But: The tag & release need to be prepended with a "v". So it needs to be v0.0.1, v0.0.2

Well, then the following section in the docs is clearly a lie:

The GitHub tag is in the format of (prefix-)(v)1.0.0, where prefix and v are optional and 1.0.0 is the version number. Here are the examples of valid GitHub tags: 1.0.1, 1.0, 1, v1.0.1, v1.0

Taken from here

It might be worth to fix this upstream then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants