chore: Remove unused scripts #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as "draft" but is in "Waitig for review"? Shall we move it back for now? |
|
Yeah I wanted to add the smoke tests in https://github.com/stackabletech/actions first, let's move it back. |
|
The |
NickLarsenNZ
requested changes
Oct 21, 2024
There was a problem hiding this comment.
As per @xeniape's comment, we should only remove the enumerate-product-versions.py scripts once it is no longer used.
This restores the enumerate-product-versions script.
Techassi
force-pushed
the
chore/remove-unused-scripts
branch
from
401febc to
9edb2c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a bunch of unused scripts.
Some of these scripts need to be added to https://github.com/stackabletech/actions and referred to with
${{ github.action_path }}in these actions. All files required to run these actions must be contained in thestackabletech/actionsrepository.