chore(superset): update setuptools #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does setuptools end up in the final image? (Doesn't change the fact that we should upgrade) |
|
It does, you can see the dependency tree here for example: https://secobserve.stackable.tech/#/observations/1514479/show I have not validated or analyzed it further though. I don't know too much about Python, but I also thought that |
|
I also don't know enough about Python but to me that's unexpected. But what do I know :) |
lfrancke
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setuptools was pinned to version 66.1.1 in #307. That package contains a vulnerability (CVE-2024-6345). I bumped the dependency to the latest version, building and running Superset in my test cluster worked fine. I only tested with Superset 4.0.2, as that is currently the only version we plan to ship with SDP 24.11.