Skip to content

feat: Disable NiFi 2.0 SNI check #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: Disable NiFi 2.0 SNI check #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ddcfd8
feat: Disable NiFi 2.0 SNI check
sbernauer Oct 24, 2024
e1fca41
changelog
sbernauer Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ All notable changes to this project will be documented in this file.
- Make username, user id, group id configurable, use numeric ids everywhere, change group of all files to 0 ([#849], [#890], [#897]).
- ci: Bump `stackabletech/actions` to 0.0.7 ([#901], [#903]).
- ubi-rust-builder: Bump Rust toolchain to 1.81.0 ([#902]).
- nifi: Disable the SNI check in NiFi 2.0, see [the decision](https://github.com/stackabletech/decisions/issues/34) ([#908]).

### Removed

Expand Down Expand Up @@ -93,6 +94,7 @@ All notable changes to this project will be documented in this file.
[#901]: https://github.com/stackabletech/docker-images/pull/901
[#902]: https://github.com/stackabletech/docker-images/pull/902
[#903]: https://github.com/stackabletech/docker-images/pull/903
[#908]: https://github.com/stackabletech/docker-images/pull/908

## [24.7.0] - 2024-07-24

Expand Down
13 changes: 13 additions & 0 deletions nifi/stackable/patches/2.0.0-M4/004-disable-sni-check.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/StandardServerConnectorFactory.java b/nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/StandardServerConnectorFactory.java
index 1f36ca1116..87e04091c9 100644
--- a/nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/StandardServerConnectorFactory.java
+++ b/nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/StandardServerConnectorFactory.java
@@ -183,6 +183,8 @@ public class StandardServerConnectorFactory implements ServerConnectorFactory {
httpConfiguration.setSendServerVersion(SEND_SERVER_VERSION);

final SecureRequestCustomizer secureRequestCustomizer = new SecureRequestCustomizer();
+ // Disable the SNI check, see https://github.com/stackabletech/decisions/issues/34
+ secureRequestCustomizer.setSniHostCheck(false);
httpConfiguration.addCustomizer(secureRequestCustomizer);
}