Skip to content

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Oct 24, 2024

Description

Important

This fixes the workflows which were broken in #907.

Bump stackabletech/actions to 0.1.0.

This requires the free-disk-space action to be run directly in the workflow instead of being part of the build actions. See stackabletech/actions#14.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Add an entry to the CHANGELOG.md file
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

This requires the free-disk-space action to be run directly in the workflow instead of being part of the build actions.
@NickLarsenNZ NickLarsenNZ self-assigned this Oct 24, 2024
Jimvin
Jimvin previously approved these changes Oct 24, 2024
Copy link
Member

@Jimvin Jimvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lfrancke
lfrancke previously approved these changes Oct 24, 2024
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog maybe or did I miss it?

@NickLarsenNZ NickLarsenNZ dismissed stale reviews from lfrancke and Jimvin via 79f0b07 October 24, 2024 18:18
Copy link
Member

@Jimvin Jimvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rereviewed and approved

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 3ab4cfe Oct 24, 2024
2 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/free-disk-space-path branch October 24, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants