Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Oct 29, 2024

Description

Part of: stackabletech/issues#644

This image is used to deploy the secret and listener ops in OLM environments.

yq is needed to manipulate the OLM manifests in order to append user defined tolerations and environment variables.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@razvan razvan self-assigned this Oct 29, 2024
@razvan razvan requested a review from a team October 29, 2024 14:39
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 29, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the curl options that should come from curlrc

lfrancke
lfrancke previously approved these changes Oct 29, 2024
@lfrancke
Copy link
Member

Could you please add a comment why we install yq?

@lfrancke lfrancke disabled auto-merge October 29, 2024 17:25
@razvan
Copy link
Member Author

razvan commented Oct 29, 2024

Could you please add a comment why we install yq?

done

@razvan razvan requested a review from lfrancke October 29, 2024 20:15
@lfrancke lfrancke added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit d8cae9f Oct 29, 2024
2 checks passed
@lfrancke lfrancke deleted the feat/tools-yq branch October 29, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants