Skip to content

Conversation

@maltesander
Copy link
Member

Description

  • Replace NiFi 2.0.0-M4 with 2.0.0
  • Removed switch from Dockerfile for NiFi version 1.21 (which was not built from source). Now all versions are built from source.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@maltesander maltesander requested a review from a team November 6, 2024 09:59
@maltesander maltesander self-assigned this Nov 6, 2024
soenkeliebau
soenkeliebau previously approved these changes Nov 6, 2024
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me - haven't built and tested it though.
Also, something in precommit barfs..

sbernauer
sbernauer previously approved these changes Nov 6, 2024
NickLarsenNZ

This comment was marked as outdated.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 82fb887 Nov 7, 2024
2 checks passed
@maltesander maltesander deleted the nifi-2.0.0 branch November 7, 2024 14:54
@lfrancke lfrancke changed the title Add support for NiFi 2.0.0 Add experimental support for NiFi 2.0.0 Nov 13, 2024
@lfrancke
Copy link
Member

The release notes need to specify that this is experimental.

@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/24.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants