Skip to content

Conversation

@sbernauer
Copy link
Member

Description

Please add a description here.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@sbernauer sbernauer self-assigned this Nov 7, 2024
@sbernauer sbernauer requested a review from razvan December 13, 2024 11:32
@sbernauer
Copy link
Member Author

Build passed locally

@sbernauer sbernauer added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 192c3f3 Dec 16, 2024
2 of 3 checks passed
@sbernauer sbernauer deleted the docs/airflow-libs branch December 16, 2024 15:12
@lfrancke
Copy link
Member

I don't want to have this style. Not because I don't like it but because I value consistency more.
I'll put up a follow-up PR to "fix" this (I know that it's subjective).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants