Skip to content

Conversation

@lfrancke
Copy link
Member

@lfrancke lfrancke commented Nov 7, 2024

Description

This includes an updated version of the Prometheus client which fixes a performance regression in 1.0.1.

Unfortunately there was no release of JMX Exporter 1.0.2 in time for our SDP 24.11 release so we decided to just build a custom version off main as of commit 193f6f5819a07093853f71f1b4094ccc7e67912f

Definition of Done Checklist

- [x] Add an entry to the CHANGELOG.md file
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@lfrancke lfrancke self-assigned this Nov 7, 2024
@lfrancke lfrancke requested a review from NickLarsenNZ November 7, 2024 13:49
This includes an updated version of the Prometheus client which fixes a
performance regression in 1.0.1.

Unfortunately there was no release of JMX Exporter 1.0.2 in time for our
SDP 24.11 release so we decided to just build a custom version off main
as of commit  193f6f5819a07093853f71f1b4094ccc7e67912f
NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 7, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke requested a review from NickLarsenNZ November 7, 2024 13:56
@lfrancke lfrancke changed the title Update JMX Exporter to a custom built version of 1.0.1 Update JMX Exporter to a custom-built version of 1.0.1 Nov 7, 2024
@lfrancke lfrancke enabled auto-merge November 7, 2024 13:56
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit b8a1ced Nov 7, 2024
2 checks passed
@lfrancke lfrancke deleted the push-yzplmlypnpww branch November 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants