Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Nov 11, 2024

Description

See stackabletech/issues#527

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [x] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [x] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@nightkr nightkr marked this pull request as draft November 11, 2024 14:56
@nightkr
Copy link
Contributor Author

nightkr commented Dec 9, 2024

Tested by hand in the zookeeper image, not covered by the existing integration tests since this is new functionality (that intentionally fails-safe).

@nightkr
Copy link
Contributor Author

nightkr commented Dec 9, 2024

We could verify the git commit hash, but we should probably integrate that with renovate too, then..

@nightkr nightkr marked this pull request as ready for review December 9, 2024 13:03
@nightkr nightkr requested review from a team and razvan December 9, 2024 13:03
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested manually with the Airflow image.

@nightkr nightkr added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit d27aec5 Dec 9, 2024
3 checks passed
@nightkr nightkr deleted the feature/containerdebug branch December 9, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants