Skip to content

Conversation

@Jimvin
Copy link
Member

@Jimvin Jimvin commented Nov 22, 2024

Description

Please add a description here.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Changes are OpenShift compatible
- [x] All added packages (via microdnf or otherwise) have a comment on why they are added
- [x] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a CHANGELOG entry.

Also, if we want it shipped in 24.11, we need a release-notes tag on it so it ends up in the release notes.

@Jimvin Jimvin changed the title Nifi hadoop azure Add NiFi hadoop Azure and GCP libraries Nov 22, 2024
@Jimvin Jimvin added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 22, 2024
@Jimvin Jimvin requested a review from NickLarsenNZ November 22, 2024 11:30
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more change

@NickLarsenNZ
Copy link
Member

If this is going in 24.11 (needs approval), then:

  • The change needs cherry-picking into release-24.11
  • The 24.11.0 tag needs deleting and recreating (triggers all images to build)

Otherwise:

  • The changelog entry needs moving into the Unreleased section

@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Nov 22, 2024

Sorry @Jimvin, I think we'll defer this until after the release. It will save us a bunch of extra work before we officially release.

All that means is the changelog needs updating (to have things under the Unreleased section), then it can be merged.

I'm happy to do that change for you, just give a 👍 and I'll do it.

@NickLarsenNZ
Copy link
Member

Release Note

* NiFi: Add hadoop libraries for accessing Azure and GCP.

@NickLarsenNZ NickLarsenNZ self-requested a review November 22, 2024 13:53
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jimvin Jimvin added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 6243c6a Nov 22, 2024
2 checks passed
@Jimvin Jimvin deleted the nifi-hadoop-azure branch November 22, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/25.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants