Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Oct 31, 2024

Check and Update Getting Started Script

Part of stackabletech/issues#657.
Uses --server-side for deploying druid resource so that null fields are honoured.

Note

During a Stackable release we need to check (and optionally update) the
getting-started scripts to ensure they still work after product and operator
updates.

# Some of the scripts are in a code/ subdirectory
# pushd docs/modules/superset/examples/getting_started
# pushd docs/modules/superset/examples/getting_started/code
pushd $(fd -td getting_started | grep examples); cd code 2>/dev/null || true

# Make a fresh cluster (~12 seconds)
kind delete cluster && kind create cluster
./getting_started.sh stackablectl

# Make a fresh cluster (~12 seconds)
kind delete cluster && kind create cluster
./getting_started.sh helm

popd

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand how this fixes it, but given it is for demo purposes I think if it works it is ok.

Does this change much for production users?

@adwk67
Copy link
Member Author

adwk67 commented Nov 2, 2024

I don't fully understand how this fixes it, but given it is for demo purposes I think if it works it is ok.

Does this change much for production users?

It seems that some client tools in some versions (in this case, kubectl) try to resolve the nullable-yet-having-a-default character of CRD fields before sending it to the server: with --server-side, the CRD definition is honoured as-is, but has the downside of being a bit "brute-force" (i.e. possibly causing problems if resources are patched concurrently). So this may affect how customers deploy resources.

@adwk67 adwk67 added this pull request to the merge queue Nov 2, 2024
Merged via the queue into main with commit 8055089 Nov 2, 2024
17 checks passed
@adwk67 adwk67 deleted the fix/getting-started-pre-24.11 branch November 2, 2024 13:23
@adwk67
Copy link
Member Author

adwk67 commented Nov 2, 2024

Opened an issue here: stackabletech/issues#663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants