Skip to content

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jan 31, 2025

Part of stackabletech/issues#642

This PR adds versioning to the Druid CRD and cluster config. It doesn't introduce any new version or updates the CRD in any way. It currently emits the same crd.yaml which is the correct expected behaviour.

Tip

It is recommended to look at this PR on a commit-by-commit basis to better understand the individual steps taken. Also take a look at the macro documentation.

@Techassi Techassi self-assigned this Jan 31, 2025
@Techassi Techassi marked this pull request as ready for review February 4, 2025 09:01
@Techassi
Copy link
Member Author

Techassi commented Feb 4, 2025

This PR is basically ready, but currently blocked stackabletech/operator-templating#483 and its rollout.

EDIT: Not blocked anymore.

@Techassi Techassi changed the title chore: Add CRD versioning chore: Version CRD and DruidClusterConfig Feb 4, 2025
@razvan razvan self-requested a review February 12, 2025 08:33
razvan
razvan previously approved these changes Feb 12, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@razvan razvan added this pull request to the merge queue Feb 12, 2025
@razvan razvan removed this pull request from the merge queue due to a manual request Feb 12, 2025
@razvan razvan enabled auto-merge February 12, 2025 13:23
@razvan razvan added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 267f1a6 Feb 12, 2025
17 checks passed
@razvan razvan deleted the chore/add-crd-versioning branch February 12, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants