Skip to content

chore: Remove hardcoded uid and gid #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

chore: Remove hardcoded uid and gid #718

merged 1 commit into from
May 8, 2025

Conversation

@lfrancke
Copy link
Member

@lfrancke lfrancke commented May 6, 2025 •
edited
Loading

Description

Part of stackabletech/issues#651

Remove hardcoded uid and gid, they'll default to the ones from the docker images now.
For 25.7 that means they might change from 1000/0
See stackabletech/docker-images#916 for details

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • Integration tests passed (for non trivial changes)

Reviewer

  • Documentation added or updated. Follows the style guide.
  • Changelog updated

Acceptance

  • Proper release label has been added

@lfrancke lfrancke force-pushed the feat/hardcoded-uid-gid branch 2 times, most recently from aa4acd9 to 9b51e02 Compare May 6, 2025 12:34
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering May 6, 2025
@lfrancke lfrancke mentioned this pull request May 6, 2025
Closed
32 tasks
@lfrancke lfrancke self-assigned this May 6, 2025
@lfrancke lfrancke force-pushed the feat/hardcoded-uid-gid branch from 9b51e02 to 9777879 Compare May 7, 2025 20:24
@lfrancke lfrancke changed the title Remove hardcoded uid and gid, they'll default to the ones from the do… Remove hardcoded uid and gid May 7, 2025
@sbernauer sbernauer self-requested a review May 8, 2025 06:59
sbernauer
sbernauer reviewed May 8, 2025
View reviewed changes
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 8, 2025
sbernauer
sbernauer previously approved these changes May 8, 2025
View reviewed changes
@sbernauer sbernauer changed the title Remove hardcoded uid and gid chore: Remove hardcoded uid and gid May 8, 2025
@lfrancke
Copy link
Member Author

lfrancke commented May 8, 2025

I messed up something in git. I will try to unmess it

@lfrancke lfrancke force-pushed the feat/hardcoded-uid-gid branch from 24ff59a to 4317942 Compare May 8, 2025 14:14
@lfrancke
Copy link
Member Author

lfrancke commented May 8, 2025

Sorry, I could only get it unstuck by force-pushing.

@lfrancke lfrancke requested a review from sbernauer May 8, 2025 14:14
@sbernauer
Copy link
Member

Thanks!

@lfrancke lfrancke enabled auto-merge May 8, 2025 14:20
@lfrancke lfrancke moved this from Development: In Review to Development: Done in Stackable Engineering May 8, 2025
@lfrancke lfrancke added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit df5cd27 May 8, 2025
17 checks passed
@lfrancke lfrancke deleted the feat/hardcoded-uid-gid branch May 8, 2025 14:32
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@lfrancke lfrancke

Labels

release/25.7.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lfrancke @sbernauer