Skip to content

Conversation

@dervoeti
Copy link
Member

@dervoeti dervoeti commented Jun 30, 2025

Description

The "overrides" test still had the default timeout of 5 minutes to wait for the HdfsCluster, which is a bit short and sometimes caused the test to fail. I adjusted it to 10 minutes, like in the other tests.

Successful test: https://testing.stackable.tech/job/druid-operator-it-custom/52/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@dervoeti dervoeti self-assigned this Jun 30, 2025
@dervoeti dervoeti force-pushed the fix/test-timeouts branch from 8881181 to d9602ce Compare June 30, 2025 15:00
@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Jun 30, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 30, 2025
@dervoeti dervoeti added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit eb1eef4 Jun 30, 2025
17 checks passed
@dervoeti dervoeti deleted the fix/test-timeouts branch June 30, 2025 21:17
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 2, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants