Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 29, 2025

Description

While checking this I noticed TLS handling in druid-operator looks buggy to me.
Given it's Druid I did not further investigate, but restored the previous behavior of keytool.
The test should now pass again.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Sep 29, 2025
@sbernauer sbernauer moved this to Development: In Progress in Stackable Engineering Sep 29, 2025
@sbernauer
Copy link
Member Author

@sbernauer
Copy link
Member Author

Failed test passed locally

        --- PASS: kuttl/harness/ldap_druid-33.0.0_zookeeper-latest-3.9.3_opa-1.4.2_hadoop-latest-3.4.1_ldap-use-tls-true_ldap-no-bind-credentials-false_openshift-false (642.15s)

@sbernauer sbernauer moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Sep 29, 2025
@maltesander maltesander self-requested a review September 30, 2025 07:36
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 30, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer enabled auto-merge September 30, 2025 07:55
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Sep 30, 2025
@sbernauer sbernauer added this pull request to the merge queue Sep 30, 2025
Merged via the queue into main with commit 07e24a3 Sep 30, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/tls-handling branch September 30, 2025 08:04
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants