Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 11, 2025

Description

Hopefully fixes https://testing.stackable.tech/job/druid-operator-it-custom/66/consoleFull, so let's give it a try

               volumes:
               - ephemeral:
                   volumeClaimTemplate:
                     metadata:
                       annotations:
        +                secrets.stackable.tech/backend.autotls.cert.lifetime: 1d
                         secrets.stackable.tech/class: tls
        +                secrets.stackable.tech/format: tls-pkcs12
        +                secrets.stackable.tech/format.compatibility.tls-pkcs12.password: changeit
                         secrets.stackable.tech/scope: pod
        -              creationTimestamp: null
                     spec:

.spec.template.spec.volumes.ephemeral.volumeClaimTemplate.metadata.creationTimestamp: key is missing from map

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Nov 11, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Nov 11, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer enabled auto-merge November 11, 2025 14:40
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Nov 11, 2025
@sbernauer sbernauer added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit 80d2083 Nov 11, 2025
17 checks passed
@sbernauer sbernauer deleted the test/relax-assert branch November 11, 2025 14:56
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants