Skip to content

Conversation

razvan
Copy link
Member

@razvan razvan commented Aug 30, 2024

Description

These tests were left out of custom image support previously because they only use the hbase-latest dimension.

But it turns out that it's nice to have a fully green test run with a custom image across the board.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan enabled auto-merge August 30, 2024 12:45
@razvan razvan requested a review from a team August 30, 2024 12:45
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 4b052f6 Aug 30, 2024
30 checks passed
@razvan razvan deleted the fix/custom-image-tests branch August 30, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants