Skip to content

chore: Remove hardcoded uid and gid #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

chore: Remove hardcoded uid and gid #660

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
530260a
Remove hardcoded uid and gid, they'll default to the ones from the do…
lfrancke May 7, 2025
9eb9a9d
Merge main and fix conflict
lfrancke May 8, 2025
2821737
fix changelog
lfrancke May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
- BREAKING: Inject the vector aggregator address into the vector config using the env var `VECTOR_AGGREGATOR_ADDRESS` instead
of having the operator write it to the vector config ([#645]).
- test: Bump to Vector `0.46.1` ([#657]).
- Previously this operator would hardcode the UID and GID of the Pods being created to 1000/0, this has changed now ([#660])
- The defaults from the docker images itself will now apply, which will be different from 1000/0 going forward

### Fixed

Expand All @@ -39,6 +41,7 @@
[#654]: https://github.com/stackabletech/hbase-operator/pull/654
[#655]: https://github.com/stackabletech/hbase-operator/pull/655
[#657]: https://github.com/stackabletech/hbase-operator/pull/657
[#660]: https://github.com/stackabletech/hbase-operator/pull/660

## [25.3.0] - 2025-03-21

Expand Down
9 changes: 1 addition & 8 deletions rust/operator-binary/src/hbase_controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ const HBASE_CONFIG_TMP_DIR: &str = "/stackable/tmp/hbase";
const HBASE_LOG_CONFIG_TMP_DIR: &str = "/stackable/tmp/log_config";

const DOCKER_IMAGE_BASE_NAME: &str = "hbase";
const HBASE_UID: i64 = 1000;

pub struct Ctx {
pub client: stackable_operator::client::Client,
Expand Down Expand Up @@ -939,13 +938,7 @@ fn build_rolegroup_statefulset(
)
.context(AddVolumeSnafu)?
.service_account_name(service_account.name_any())
.security_context(
PodSecurityContextBuilder::new()
.run_as_user(HBASE_UID)
.run_as_group(0)
.fs_group(1000)
.build(),
);
.security_context(PodSecurityContextBuilder::new().fs_group(1000).build());

if let Some(ContainerLogConfig {
choice:
Expand Down