-
-
Notifications
You must be signed in to change notification settings - Fork 4
chore: advertise restserver in rolegroup configmap #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
This is not in 25.11, correct? |
No, not in 25.11 Release Note
Adjusted Release Note in #716 (comment) |
Description
Implementation of #669
Adds
hbase.rest.hostnamehbase.rest.porthbase.rest.info.portproperties to the restserver rolegroup configmap.
hbase.rest.hostnameandhbase.rest.info.portare not pre-existinghbase-site.xmlkeys, but were added with a similar naming scheme as master properties.Advertisement of restservers was done to be consistent with master and regionserver advertisement.
Note
(also added to the issue)
Added by @adwk67 The aim here is not to implement full discoverability for role endpoints; that should be done when we tackle that for all operators. We actually reached a point in the original implementation of HBase listener-endpoints where there was a config map (like kafka, hdfs etc.) that listed the endpoints by pod/replica, and at that point we decided against doing that as
So I understand the scope of this ticket to be about bringing the rest-server inline with the other roles, without claiming this to be the final destination.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker