Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Oct 21, 2024

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan marked this pull request as ready for review October 21, 2024 13:14
@razvan razvan self-assigned this Oct 21, 2024
@razvan razvan requested a review from a team October 21, 2024 13:14
@razvan razvan enabled auto-merge October 21, 2024 13:35
@razvan
Copy link
Member Author

razvan commented Nov 26, 2024

closing as we decided to only do this if necessary.

@razvan razvan closed this Nov 26, 2024
auto-merge was automatically disabled November 26, 2024 16:39

Pull request was closed

@lfrancke lfrancke deleted the test/shutdown-timeout branch June 26, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant