Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Nov 20, 2024

Replace hard-coded OPA version with a templated dimension.

There is a companion change for the main branch: #614.

@adwk67 adwk67 marked this pull request as ready for review November 20, 2024 10:55
@NickLarsenNZ NickLarsenNZ self-requested a review November 20, 2024 13:11
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 merged commit ffae639 into release-24.11 Nov 20, 2024
14 of 17 checks passed
spec:
image:
productVersion: 0.61.0
productVersion: "{{ test_scenario['values']['opa'] }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly recommend to make it compatible with custom images too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants