Skip to content

Conversation

@soenkeliebau
Copy link
Member

@soenkeliebau soenkeliebau commented Nov 21, 2024

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [ ] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@soenkeliebau soenkeliebau requested a review from nightkr November 25, 2024 11:46
nightkr
nightkr previously approved these changes Nov 25, 2024
Copy link
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nightkr
Copy link
Contributor

nightkr commented Nov 25, 2024

Of the build warnings:

  • markdownlint should be easy to satisfy
  • none of the rustsec warnings are all that actionable for a patch release.. we could update rustls but the mentioned issue only affects servers so I wouldn't consider it a high priority, instant and derivative are both going to require some upstream work to sort out

@nightkr nightkr dismissed their stale review November 25, 2024 12:48

Changelog issue

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sönke told me to, because everything else is merged and this way it is at least the same across the board

@soenkeliebau soenkeliebau added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 47ee88a Nov 25, 2024
16 of 17 checks passed
@soenkeliebau soenkeliebau deleted the fix/SUP-148 branch November 25, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants