Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Dec 17, 2024

Description

This should help speed up test teardown, since they handle SIGTERM instead of having to wait for the container shutdown to timeout.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

This should help speed up test teardown, since they handle SIGTERM
instead of having to wait for the container shutdown to timeout.
@nightkr nightkr requested a review from a team December 17, 2024 15:27
@razvan
Copy link
Member

razvan commented Dec 17, 2024

I don't see where tini is used.

@nightkr
Copy link
Contributor Author

nightkr commented Dec 17, 2024

It's managed by the shareProcessNamespace flag.

@nightkr nightkr added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 5e6e339 Dec 17, 2024
16 of 17 checks passed
@nightkr nightkr deleted the bugfix/test-tini branch December 17, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants