Skip to content
This repository was archived by the owner on Jun 6, 2025. It is now read-only.

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Oct 22, 2024

Description

Part of stackabletech/issues#652

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@maltesander maltesander requested a review from sbernauer October 22, 2024 08:10
@maltesander maltesander self-assigned this Oct 22, 2024
@maltesander maltesander enabled auto-merge October 23, 2024 12:55
@maltesander maltesander added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 91983a0 Oct 23, 2024
29 checks passed
@maltesander maltesander deleted the op-rs-0.79.0 branch October 23, 2024 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants