Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 15, 2024

Description

Fixes #538

This PR also adds an upgrade test to make sure the functionality will be kept going forward.

Co-developed with @xeniape

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 15, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ
Copy link
Member

Btw, you can add a Co-authered-by trailer to the commit to give @xeniape attribution (not sure if Co-developed has any significance in github if that's what you were going for).

Co-authored-by: Xenia Fischer <[email protected]>
@sbernauer
Copy link
Member Author

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hive-operator-it-custom/6

NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 15, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer
Copy link
Member Author

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the upgrade test

@sbernauer
Copy link
Member Author

All tests passed

@sbernauer sbernauer added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 523b904 Nov 15, 2024
16 of 17 checks passed
@sbernauer sbernauer deleted the fix/upgrade branch November 15, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HMS update 3.1.3 -> 4.0.0 fails

2 participants