Skip to content

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Mar 10, 2025

Description

Increase the default memory reservation to 768Mi to avoid OOMKilled.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@NickLarsenNZ NickLarsenNZ moved this to Development: Waiting for Review in Stackable Engineering Mar 10, 2025
@NickLarsenNZ NickLarsenNZ added scheduled-for/25.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 10, 2025
@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Mar 10, 2025

Release Note

The the default memory reservation has been increased from 512Mi to 768Mi to avoid OOMKilled events.

sbernauer
sbernauer previously approved these changes Mar 11, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 11, 2025
Co-authored-by: Sebastian Bernauer <[email protected]>
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Mar 11, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Mar 11, 2025
Merged via the queue into main with commit 7abce3b Mar 11, 2025
16 of 17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the increase-default-mem-limit branch March 11, 2025 10:28
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/25.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants