Skip to content

feat!: Use Tracing::pre_configured from stackable-telemetry #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2025
Merged

feat!: Use Tracing::pre_configured from stackable-telemetry #592

merged 4 commits into from
Apr 10, 2025

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Apr 9, 2025 •
edited
Loading

Use Tracing::pre_configured from stackable-telemetry

Part of stackabletech/issues#639.

Breaking changes:

operator-binary

  • The console log level was set by HIVE_OPERATOR_LOG, and is now set by CONSOLE_LOG.
  • The file log level was set by HIVE_OPERATOR_LOG, and is now set by FILE_LOG.
  • The file log directory was previously changed to ROLLING_LOGS, but has been updated to ROLLING_LOGS_DIR.

Testing

--- PASS: kuttl (163.12s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/logging_postgres-12.5.6_hive-4.0.1_openshift-false (163.11s)
PASS

@NickLarsenNZ NickLarsenNZ self-assigned this Apr 9, 2025
@NickLarsenNZ NickLarsenNZ moved this to Development: In Progress in Stackable Engineering Apr 9, 2025
@NickLarsenNZ NickLarsenNZ mentioned this pull request Apr 9, 2025
Closed
@NickLarsenNZ NickLarsenNZ moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Apr 9, 2025
@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Apr 9, 2025 •
edited
Loading

FYI, the changelog has been updated, the commit is just delayed in Github:

image

Well it's been 10 hours - must be almost done, right?

@NickLarsenNZ NickLarsenNZ reopened this Apr 10, 2025
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 10, 2025
@Techassi Techassi enabled auto-merge April 10, 2025 08:10
@Techassi Techassi added this pull request to the merge queue Apr 10, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Apr 10, 2025
Merged via the queue into main with commit 18ab332 Apr 10, 2025
33 checks passed
@Techassi Techassi deleted the feat/use-tracing-pre-configured branch April 10, 2025 08:36
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NickLarsenNZ @Techassi