Skip to content

Conversation

@xeniape
Copy link
Member

@xeniape xeniape commented Aug 5, 2025

Description

Follow up to #622
Noticed in stackabletech/trino-operator#784 that minio Chart values were incorrect for the installed version. Following up with a fix in this PR.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Aug 5, 2025
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Aug 5, 2025
@adwk67 adwk67 self-requested a review August 11, 2025 10:17
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 11, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (ran one test from each category successfully)

@xeniape
Copy link
Member Author

xeniape commented Aug 11, 2025

Thank you!

@xeniape xeniape enabled auto-merge August 11, 2025 13:19
@xeniape xeniape added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit 19cf07e Aug 11, 2025
17 checks passed
@xeniape xeniape deleted the chore/fix-minio-values-bitnami-migration branch August 11, 2025 13:28
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Aug 12, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants