Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Jan 22, 2025

Description

See #765

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@nightkr
Copy link
Contributor Author

nightkr commented Jan 22, 2025

Release note:

The -nodeport discovery ConfigMaps have been deprecated for removal. Use the primary discovery CMs instead. See #765 for more information.

@nightkr nightkr requested a review from a team January 22, 2025 16:23
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nightkr nightkr added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 26b1220 Jan 23, 2025
17 checks passed
@nightkr nightkr deleted the chore/deprecate-nodeport-discovery branch January 23, 2025 11:25
@lfrancke lfrancke added release/25.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/25.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants