Skip to content

Conversation

razvan
Copy link
Member

@razvan razvan commented Oct 13, 2025

Description

Part of: #870

This implements the following next step in the issue above:

GracefulShutdown improvements: Currently Prestop sleep hook is used in the Controller to provide brokers more time to off load when shutting down the cluster. This is a beta feature until Kubernetes 1.34 and must be replaced since we do not want to use beta features. We want to do this timeboxed (4h) if e.g. autodetection of the Kubernetes version / Endpoint to request features is possible and we switch from Prestop hook to a different implementation.

Regarding feature detection: feature gates cannot be queried via the kube api and the preStop property is behind the ContainerStopSignals gate defined by KEP4960.

Tested locally:

--- PASS: kuttl (154.10s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke-kraft_kafka-kraft-4.1.0_openshift-false (154.08s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Oct 13, 2025
@razvan razvan requested a review from maltesander October 13, 2025 11:52
@razvan razvan enabled auto-merge October 13, 2025 11:53
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit 9166590 Oct 14, 2025
17 checks passed
@razvan razvan deleted the issue/870-remove-pre-stop branch October 14, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants