Skip to content

fix: Fix republishing volumes after a Node restart #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2025
Merged

fix: Fix republishing volumes after a Node restart #284

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2747cde
fix: Fix an error after a Node restart
siegfriedweber Mar 7, 2025
3dc5186
Check if the default-address symlink needs to be updated
siegfriedweber Mar 7, 2025
c2ef060
chore: Fix clippy warning
siegfriedweber Mar 7, 2025
a905976
chore: Upgrade ring
siegfriedweber Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,15 @@ All notable changes to this project will be documented in this file.
### Fixed

- Give RBAC permission to `delete` Services, which is needed to set an ownerRef on already existing Services ([#283]).
- Fix the error "failed to write content: File exists (os error 17)" after a
Node restart ([#284]).

[#267]: https://github.com/stackabletech/listener-operator/pull/267
[#268]: https://github.com/stackabletech/listener-operator/pull/268
[#279]: https://github.com/stackabletech/listener-operator/pull/279
[#282]: https://github.com/stackabletech/listener-operator/pull/282
[#283]: https://github.com/stackabletech/listener-operator/pull/283
[#284]: https://github.com/stackabletech/listener-operator/pull/284

## [24.11.1] - 2025-01-10

Expand Down
8 changes: 7 additions & 1 deletion rust/operator-binary/src/csi_server/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,12 +591,18 @@ mod pod_dir {
}
default_addr_dir.get_or_insert(addr_dir);
}

let default_addr_link = target_path.join("default-address");
// Remove any existing symlink because `tokio::fs::symlink` fails if it already exists.
// This happens if the node was restarted. The pod then restarts with the same UID and
// the pre-populated volume.
let _ = tokio::fs::remove_file(&default_addr_link).await;
tokio::fs::symlink(
default_addr_dir
.context(NoDefaultAddressSnafu)?
.strip_prefix(target_path)
.context(DefaultAddrIsOutsideRootSnafu)?,
target_path.join("default-address"),
&default_addr_link,
)
.await?;
Ok(())
Expand Down
Loading