Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Mar 19, 2025

Description

Fixes #286

Copied over from secret-operator

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

Fixes #286

Copied over from secret-operator
@nightkr nightkr requested a review from a team March 19, 2025 09:22
@nightkr nightkr moved this to Development: Waiting for Review in Stackable Engineering Mar 19, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Did you intentionally skip Microk8s?

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 19, 2025
@nightkr
Copy link
Contributor Author

nightkr commented Mar 20, 2025

Microk8s was already there. :P

@nightkr nightkr added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 10c650a Mar 20, 2025
17 checks passed
@nightkr nightkr deleted the docs/tanzu-kubeletdir branch March 20, 2025 11:24
@sbernauer
Copy link
Member

Missed that 🤦

@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Mar 20, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Document kubeletDir for VMware Tanzu

4 participants