Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Feb 14, 2025

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer self-assigned this Feb 14, 2025
@siegfriedweber siegfriedweber self-requested a review February 18, 2025 10:41
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some language proposals, LGTM otherwise :)

sbernauer and others added 2 commits February 19, 2025 13:05
Co-authored-by: Siegfried Weber <[email protected]>
Co-authored-by: Malte Sander <[email protected]>
@sbernauer
Copy link
Member Author

@siegfriedweber I did pull in all changes not related to line length.
Can you please render the docs again and have another look if they are now looking fine for you?

Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spelling improve, but otherwise LGTM

@sbernauer
Copy link
Member Author

Thanks for the review!

@sbernauer sbernauer added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit f657452 Feb 26, 2025
17 checks passed
@sbernauer sbernauer deleted the docs/python-processors branch February 26, 2025 12:41
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 5, 2025
@sbernauer sbernauer mentioned this pull request Apr 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants