Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Apr 29, 2025

Description

Part of #738
Needs stackabletech/docker-images#1060

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@sbernauer sbernauer moved this to Development: In Progress in Stackable Engineering Apr 29, 2025
@sbernauer
Copy link
Member Author

@sbernauer sbernauer moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering May 8, 2025
@sbernauer sbernauer self-assigned this May 8, 2025
@NickLarsenNZ NickLarsenNZ self-requested a review May 15, 2025 08:12
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 15, 2025
@sbernauer sbernauer mentioned this pull request May 20, 2025
3 tasks
@sbernauer
Copy link
Member Author

NickLarsenNZ
NickLarsenNZ previously approved these changes May 21, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want this

@sbernauer sbernauer requested a review from NickLarsenNZ May 21, 2025 07:55
@sbernauer
Copy link
Member Author

Tests passed 🚀

@sbernauer sbernauer enabled auto-merge May 21, 2025 08:25
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue May 21, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 21, 2025
Merged via the queue into main with commit 8b1cc2a May 21, 2025
16 of 17 checks passed
@sbernauer sbernauer deleted the test/iceberg branch May 21, 2025 08:35
labrenbe pushed a commit that referenced this pull request May 21, 2025
* Clean up smoke test

* clean up smoke test part 2

* Add working test :)

* Move files

* Add and test HDFS functionality

* Kerbize HDFS and HMS

* Add Kerberos test

* Use nightly image

* linter

* Update Iceberg docs

* changelog

* Small bumps

* Update docs/modules/nifi/pages/usage_guide/writing-to-iceberg-tables.adoc

Co-authored-by: Nick <[email protected]>

---------

Co-authored-by: Nick <[email protected]>
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 21, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 4, 2025
* add support for listeners

* add very basic integration test

* add pr number to changelog

* add external-access test

* chore: Add NiFi 2.4.0 and remove 2.2.0 (#797)

add NiFi 2.4.0 and remove 2.2.0

* test: Add test for Apache Iceberg integration (#785)

* Clean up smoke test

* clean up smoke test part 2

* Add working test :)

* Move files

* Add and test HDFS functionality

* Kerbize HDFS and HMS

* Add Kerberos test

* Use nightly image

* linter

* Update Iceberg docs

* changelog

* Small bumps

* Update docs/modules/nifi/pages/usage_guide/writing-to-iceberg-tables.adoc

Co-authored-by: Nick <[email protected]>

---------

Co-authored-by: Nick <[email protected]>

* wip: update listener implementation based on implementation for superset operator

* use single listener with pvc  per rolegroup

* update integration tests with crd change

* restore iceberg test file

* fix listener class in iceberg test

* expose https port in headless service

* update comment

* address feedback from review

* remove unused error variants

* create headless service name in function

* remove unused functions

* move listenerClass to roleConfig

* use new headless service name in integration tests

* move listener constants to listener module

* remove duplicate iceberg test

* remove hard-coded names

* fix integration tests

* remove hardcoded role name

* improve code quality

* set rolegroup label on listener pvcs to none

* fix app version label on listener

* set rolegroup label on listener pvcs

* remove listener class from trino in iceberg test

* add note on custom ListenerClasses to docs

* remove version argument in reporting task

* rename headless service

* fix iceberg test

* create separate headless services

* add missing file

* fix iceberg test

* use listener scope for tls

---------

Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Nick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants