-
-
Notifications
You must be signed in to change notification settings - Fork 8
docs: Document workaround to disable SNI checks #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we should hold of merging until stackabletech/docker-images#1225 is merged.
Can you please also add a docs:
prefix to the PR title? :)
If you have the time I would also be happy about a changelog entry that you can now disable the check via configOverrides (yeah, this is a docker-image thing, but users are not going to read docker-images changelog)
I thought about that and wasn't sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM, thanks @xeniape for the suggestions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments and suggestions.
Hopefully we can remove the SNI workarounds soon.
Not sure who is supposed to resolve or reply to my comments. |
I hope I caught all comments. It should be ready for review again. |
Co-authored-by: Xenia <[email protected]>
Co-authored-by: Xenia <[email protected]>
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
I have decided to go with my original proposal for the two comments you disagree with, incorporated another and believe you're wrong about the last. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, ship it :D
Now it has conflicts and I can't merge it from the phone :) I'll try to fix that in the next few days. |
Description
Important
This should only be merged once stackabletech/docker-images#1225 is merged
Document workaround to disable SNI checks.
I took the opportunity to rewrite the entire FAQ entry.