fix: Fix new Clippy errors introduced in Rust 1.80.0

Author: Techassi

crates/stackable-operator/src/client.rs

@@ -373,15 +373,15 @@ impl Client {
 
     /// There are four different patch strategies:
     /// 1) Apply (<https://kubernetes.io/docs/reference/using-api/api-concepts/#server-side-apply>)
-    ///   Starting from Kubernetes v1.18, you can enable the Server Side Apply feature so that the control plane tracks managed fields for all newly created objects.
+    ///    Starting from Kubernetes v1.18, you can enable the Server Side Apply feature so that the control plane tracks managed fields for all newly created objects.
     /// 2) Json (<https://tools.ietf.org/html/rfc6902>):
-    ///   This is supported on crate feature jsonpatch only
+    ///    This is supported on crate feature jsonpatch only
     /// 3) Merge (<https://tools.ietf.org/html/rfc7386>):
-    ///   For example, if you want to update a list you have to specify the complete list and update everything
+    ///    For example, if you want to update a list you have to specify the complete list and update everything
     /// 4) Strategic (not for CustomResource)
-    ///   With a strategic merge patch, a list is either replaced or merged depending on its patch strategy.
-    ///   The patch strategy is specified by the value of the patchStrategy key in a field tag in the Kubernetes source code.
-    ///   For example, the Containers field of PodSpec struct has a patchStrategy of merge.
+    ///    With a strategic merge patch, a list is either replaced or merged depending on its patch strategy.
+    ///    The patch strategy is specified by the value of the patchStrategy key in a field tag in the Kubernetes source code.
+    ///    For example, the Containers field of PodSpec struct has a patchStrategy of merge.
     async fn patch_status<T, S>(
         &self,
         resource: &T,

crates/stackable-operator/src/commons/listener.rs

@@ -110,7 +110,7 @@ pub enum KubernetesTrafficPolicy {
 /// 1. It uses a cluster-level policy object (ListenerClass) to define how exactly the exposure works
 /// 2. It has a consistent API for reading back the exposed address(es) of the service
 /// 3. The Pod must mount a Volume referring to the Listener, which also allows
-/// ["sticky" scheduling](DOCS_BASE_URL_PLACEHOLDER/listener-operator/listener#_sticky_scheduling).
+///    ["sticky" scheduling](DOCS_BASE_URL_PLACEHOLDER/listener-operator/listener#_sticky_scheduling).
 ///
 /// Learn more in the [Listener documentation](DOCS_BASE_URL_PLACEHOLDER/listener-operator/listener).
 #[derive(

crates/stackable-operator/src/cpu.rs

@@ -101,12 +101,14 @@ impl Display for CpuQuantity {
 impl FromStr for CpuQuantity {
     type Err = Error;
 
-    /// Only two formats can be parsed
+    /// Only two formats can be parsed:
+    ///
     /// - {usize}m
     /// - {f32}
-    /// For the float, only milli-precision is supported.
-    /// Using more precise values will trigger an error, and using any other
-    /// unit than 'm' or None will also trigger an error.
+    ///
+    /// For the float, only milli-precision is supported. Using more precise
+    /// values will trigger an error, and using any other unit than 'm' or None
+    /// will also trigger an error.
     fn from_str(q: &str) -> Result<Self> {
         let start_of_unit = q.find(|c: char| c != '.' && !c.is_numeric());
         if let Some(start_of_unit) = start_of_unit {

crates/stackable-operator/src/memory.rs

@@ -1,7 +1,7 @@
 //! Utilities for converting Kubernetes quantities to Java heap settings.
 //! Since Java heap sizes are a subset of Kubernetes quantities, the conversion
-//! might lose precision or fail completely.
-//! In addition:
+//! might lose precision or fail completely. In addition:
+//!
 //! - decimal quantities are not supported ("2G" is invalid)
 //! - units are case sensitive ("2gi" is invalid)
 //! - exponential notation is not supported.
@@ -121,12 +121,15 @@ impl Display for BinaryMultiple {
 }
 
 /// Convert a (memory) [`Quantity`] to Java heap settings.
+///
 /// Quantities are usually passed on to container resources while Java heap
-/// sizes need to be scaled accordingly.
-/// This implements a very simple heuristic to ensure that:
+/// sizes need to be scaled accordingly. This implements a very simple heuristic
+/// to ensure that:
+///
 /// - the quantity unit has been mapped to a java supported heap unit. Java only
 ///   supports up to Gibibytes while K8S quantities can be expressed in Exbibytes.
 /// - the heap size has a non-zero value.
+///
 /// Fails if it can't enforce the above restrictions.
 #[deprecated(
     since = "0.33.0",
@@ -148,15 +151,17 @@ pub fn to_java_heap(q: &Quantity, factor: f32) -> Result<String> {
 }
 
 /// Convert a (memory) [`Quantity`] to a raw Java heap value of the desired `target_unit`.
+///
 /// Quantities are usually passed on to container resources while Java heap
-/// sizes need to be scaled accordingly.
-/// The raw heap value is converted to the specified `target_unit` (this conversion
-/// is done even if specified a unit greater that Gibibytes. It is not recommended to scale
-/// to anything bigger than Gibibytes.
-/// This implements a very simple heuristic to ensure that:
+/// sizes need to be scaled accordingly. The raw heap value is converted to the
+/// specified `target_unit` (this conversion is done even if specified a unit
+/// greater that Gibibytes. It is not recommended to scale to anything bigger
+/// than Gibibytes. This implements a very simple heuristic to ensure that:
+///
 /// - the quantity unit has been mapped to a java supported heap unit. Java only
 ///   supports up to Gibibytes while K8S quantities can be expressed in Exbibytes.
 /// - the heap size has a non-zero value.
+///
 /// Fails if it can't enforce the above restrictions.
 #[deprecated(
     since = "0.33.0",

crates/stackable-operator/src/status/condition/mod.rs

@@ -290,16 +290,20 @@ impl ClusterConditionSet {
         self.conditions[index] = Some(condition);
     }
 
-    /// Merges two [`ClusterConditionSet`]s. The condition_combiner implements the strategy used to
-    /// merge two conditions of the same `type_`.
+    /// Merges two [`ClusterConditionSet`]s.
+    ///
+    /// The condition_combiner implements the strategy used to merge two
+    /// conditions of the same `type_`.
     ///
     /// # Arguments
     ///
     /// * `other` - The [`ClusterConditionSet`] to be merged
-    /// * `condition_combiner` - This is either be `update_message` or `update_timestamps`. The
-    /// `update_message` is used to concatenate messages of the same [`ClusterConditionStatus`] and
-    /// the same [`ClusterConditionType`]. The `update_timestamps` is required to merge the old
-    /// cluster status with the new one and update transition timestamps correctly.
+    /// * `condition_combiner` - This is either be `update_message` or
+    ///   `update_timestamps`. The `update_message` is used to concatenate
+    ///   messages of the same [`ClusterConditionStatus`] and the same
+    ///   [`ClusterConditionType`]. The `update_timestamps` is required to merge
+    ///   the old cluster status with the new one and update transition
+    ///   timestamps correctly.
     fn merge(
         self,
         other: ClusterConditionSet,
@@ -361,7 +365,7 @@ fn update_timestamps(
 /// A condition combiner strategy with the following properties:
 /// 1. It preserves the condition with the highest status.
 /// 2. It joins the previous messages to the current one if both conditions
-/// have the same status.
+///    have the same status.
 fn update_message(
     old_condition: ClusterCondition,
     new_condition: ClusterCondition,

crates/stackable-telemetry/src/instrumentation/axum/mod.rs

@@ -199,8 +199,8 @@ pub trait RequestExt {
     /// section of the HTTP span semantic conventions:
     ///
     /// > HTTP server instrumentations SHOULD do the best effort when populating
-    ///   server.address and server.port attributes and SHOULD determine them by
-    ///   using the first of the following that applies:
+    /// > server.address and server.port attributes and SHOULD determine them by
+    /// > using the first of the following that applies:
     /// >
     /// > - The original host which may be passed by the reverse proxy in the
     /// >  Forwarded#host, X-Forwarded-Host, or a similar header.