refactor: Provide centralized default impls for CommonSettings trait

Author: Techassi

crates/stackable-telemetry/src/tracing/settings/console_log.rs

@@ -1,7 +1,5 @@
 //! Console Log Subscriber Settings.
 
-use tracing::level_filters::LevelFilter;
-
 use super::{Build, CommonSettings, Settings, SettingsBuilder};
 
 /// Configure specific settings for the Console Log subscriber.
@@ -78,16 +76,8 @@ impl Build<ConsoleLogSettings> for SettingsBuilder {
 }
 
 impl CommonSettings for ConsoleLogSettings {
-    fn environment_variable(&self) -> &'static str {
-        self.common_settings.environment_variable
-    }
-
-    fn default_level(&self) -> LevelFilter {
-        self.common_settings.default_level
-    }
-
-    fn enabled(&self) -> bool {
-        self.common_settings.enabled
+    fn common(&self) -> &Settings {
+        &self.common_settings
     }
 }
 

crates/stackable-telemetry/src/tracing/settings/mod.rs

@@ -13,14 +13,23 @@ pub use otlp_trace::*;
 
 /// Simplifies access common settings from subscriber specific settings.
 pub trait CommonSettings {
+    /// Access to common settings.
+    fn common(&self) -> &Settings;
+
     /// Access to the [`Settings::environment_variable`] field.
-    fn environment_variable(&self) -> &'static str;
+    fn environment_variable(&self) -> &'static str {
+        self.common().environment_variable
+    }
 
     /// Access to the [`Settings::default_level`] field.
-    fn default_level(&self) -> LevelFilter;
+    fn default_level(&self) -> LevelFilter {
+        self.common().default_level
+    }
 
     /// Access to the [`Settings::enabled`] field.
-    fn enabled(&self) -> bool;
+    fn enabled(&self) -> bool {
+        self.common().enabled
+    }
 }
 
 /// General settings that apply to any subscriber.

crates/stackable-telemetry/src/tracing/settings/otlp_log.rs

@@ -1,7 +1,5 @@
 //! OTLP Log Subscriber Settings.
 
-use tracing::level_filters::LevelFilter;
-
 use super::{Build, CommonSettings, Settings, SettingsBuilder};
 
 #[derive(Debug, Default, PartialEq)]
@@ -43,16 +41,8 @@ impl Build<OtlpLogSettings> for SettingsBuilder {
 }
 
 impl CommonSettings for OtlpLogSettings {
-    fn environment_variable(&self) -> &'static str {
-        self.common_settings.environment_variable
-    }
-
-    fn default_level(&self) -> LevelFilter {
-        self.common_settings.default_level
-    }
-
-    fn enabled(&self) -> bool {
-        self.common_settings.enabled
+    fn common(&self) -> &Settings {
+        &self.common_settings
     }
 }
 

crates/stackable-telemetry/src/tracing/settings/otlp_trace.rs

@@ -1,7 +1,5 @@
 //! OTLP Trace Subscriber Settings.
 
-use tracing::level_filters::LevelFilter;
-
 use super::{Build, CommonSettings, Settings, SettingsBuilder};
 
 #[derive(Debug, Default, PartialEq)]
@@ -43,16 +41,8 @@ impl Build<OtlpTraceSettings> for SettingsBuilder {
 }
 
 impl CommonSettings for OtlpTraceSettings {
-    fn environment_variable(&self) -> &'static str {
-        self.common_settings.environment_variable
-    }
-
-    fn default_level(&self) -> LevelFilter {
-        self.common_settings.default_level
-    }
-
-    fn enabled(&self) -> bool {
-        self.common_settings.enabled
+    fn common(&self) -> &Settings {
+        &self.common_settings
     }
 }