Skip to content

Commit d0c4a57

Browse files
committed
chore(webhook): Update dev comment
1 parent d51491e commit d0c4a57

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

crates/stackable-webhook/src/servers/conversion.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,8 @@ impl ConversionWebhookServer {
163163

164164
// This is how Kubernetes calls us, so it decides about the naming.
165165
// AFAIK we can not influence this, so this is the only SAN entry needed.
166-
// FIXME (@Techassi): The cluster domain should be included here to form FQDN of the service
166+
// TODO (@Techassi): The cluster domain should be included here, so that (non Kubernetes)
167+
// HTTP clients can use the FQDN of the service for testing or user use-cases.
167168
let subject_alterative_dns_name =
168169
format!("{operator_service_name}.{operator_namespace}.svc",);
169170

0 commit comments

Comments
 (0)