Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented May 21, 2025

Description

Hopefully one day we are able to build aws-lc-rs on nix: nix-community/crate2nix#376

cargo tree | grep aws now is empty, make run-dev works.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer changed the title fix(stackable-webhook): Avoid aws-lc-rs crate, as it block "make run-dev" fix(stackable-webhook): Avoid aws-lc-rs crate, as it blocks "make run-dev" May 21, 2025
@sbernauer sbernauer self-assigned this May 21, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering May 21, 2025
@sbernauer sbernauer changed the title fix(stackable-webhook): Avoid aws-lc-rs crate, as it blocks "make run-dev" fix(stackable-webhook): Avoid aws-lc-rs crate, as it fails in nix May 21, 2025
@sbernauer sbernauer added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 41f9832 May 21, 2025
7 of 8 checks passed
@sbernauer sbernauer deleted the fix/remove-aws-lc-rs branch May 21, 2025 10:02
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering May 26, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants