Skip to content

chore!(stackable-webhook): Default listen address to bind to all addresses #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 21, 2025
Merged

chore!(stackable-webhook): Default listen address to bind to all addresses #1045

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09f3d13
chore!(stackable-webhook): Default listen address to bind to all inte…
sbernauer May 21, 2025
6af1dfd
changelog
sbernauer May 21, 2025
f0721bc
interfaces -> addresses
sbernauer May 21, 2025
0c72fe8
DEFAULT_SOCKET_ADDR -> DEFAULT_SOCKET_ADDRESS
sbernauer May 21, 2025
b0684e6
hint on IPv6 usage
sbernauer May 21, 2025
0487584
Merge branch 'main' into chore/bind-addr
sbernauer May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/stackable-webhook/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,15 @@ All notable changes to this project will be documented in this file.

- Don't pull in the `aws-lc-rs` crate, as this currently fails to build in `make run-dev` ([#1043]).

### Changed

- BREAKING: The constant `DEFAULT_IP_ADDRESS` has been renamed to `DEFAULT_LISTEN_ADDRESS` and binds to all
interfaces (instead of only loopback) by default. This was changed because all the webhooks
deployed to Kubernetes (e.g. conversion or mutating - which this crate targets) need to be
accessible by it, which is not the case when only using loopback ([#1045]).

[#1043]: https://github.com/stackabletech/operator-rs/pull/1043
[#1045]: https://github.com/stackabletech/operator-rs/pull/1045

## [0.3.1] - 2024-07-10

Expand Down
10 changes: 6 additions & 4 deletions crates/stackable-webhook/src/constants.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ use std::net::{IpAddr, Ipv4Addr, SocketAddr};
/// The default HTTPS port `8443`
pub const DEFAULT_HTTPS_PORT: u16 = 8443;

/// The default IP address `127.0.0.1` the webhook server binds to.
pub const DEFAULT_IP_ADDRESS: IpAddr = IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1));
/// The default IP address [`Ipv4Addr::UNSPECIFIED`] (`0.0.0.0`) the webhook server binds to,
/// which represents binding on all network interfaces.
pub const DEFAULT_LISTEN_ADDRESS: IpAddr = IpAddr::V4(Ipv4Addr::UNSPECIFIED);

/// The default socket address `127.0.0.1:8443` the webhook server vinds to.
pub const DEFAULT_SOCKET_ADDR: SocketAddr = SocketAddr::new(DEFAULT_IP_ADDRESS, DEFAULT_HTTPS_PORT);
/// The default socket address `0.0.0.0:8443` the webhook server binds to.
pub const DEFAULT_SOCKET_ADDR: SocketAddr =
SocketAddr::new(DEFAULT_LISTEN_ADDRESS, DEFAULT_HTTPS_PORT);
Loading