Skip to content

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jun 13, 2025

This PR finally switches to the opentelemetry-semantic-conventions crate to use the well-defined constants instead of hard-coded strings.

This PR defines constants in addition to upstream ones to be able to use constants across the board instead of mix-and-matching constants and hard-coded strings.

@Techassi Techassi self-assigned this Jun 13, 2025
@Techassi Techassi marked this pull request as ready for review June 13, 2025 10:01
@Techassi Techassi requested a review from NickLarsenNZ June 13, 2025 10:01
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit 982e07c Jun 13, 2025
8 checks passed
@Techassi Techassi deleted the refactor/stackable-telemetry-semantic-consts branch June 13, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants