Skip to content

refactor(stackable-operator)!: Remove Result from ListenerOperatorVolumeSourceBuilder::new() #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025
Merged

refactor(stackable-operator)!: Remove Result from ListenerOperatorVolumeSourceBuilder::new() #1058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdda3fe
refactor(stackable-operator): Remove Result from ListenerOperatorVolu…
NickLarsenNZ Jun 18, 2025
66dbbdb
chore(stackable-operator): Update changelog
NickLarsenNZ Jun 18, 2025
60849d9
chore(stackable-operator): Update changelog
NickLarsenNZ Jun 18, 2025
66f70be
fix(stackable-operator): Remove unwrap from doctest
NickLarsenNZ Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/stackable-operator/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@ All notable changes to this project will be documented in this file.
### Changed

- Update `kube` to `1.1.0` ([#1049]).
- BREAKING: Return type for `ListenerOperatorVolumeSourceBuilder::new()` is no onger a `Result` ([#1058]).

### Removed

- BREAKING: Removed `last_update_time` from CRD ClusterCondition status ([#1054]).

[#1049]: https://github.com/stackabletech/operator-rs/pull/1049
[#1054]: https://github.com/stackabletech/operator-rs/pull/1054
[#1058]: https://github.com/stackabletech/operator-rs/pull/1058

## [0.93.2] - 2025-05-26

Expand Down
2 changes: 0 additions & 2 deletions crates/stackable-operator/src/builder/pod/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,6 @@ impl PodBuilder {
) -> Result<&mut Self> {
let listener_reference = ListenerReference::ListenerClass(listener_class.to_string());
let volume = ListenerOperatorVolumeSourceBuilder::new(&listener_reference, labels)
.context(ListenerVolumeSnafu { name: volume_name })?
.build_ephemeral()
.context(ListenerVolumeSnafu { name: volume_name })?;

Expand Down Expand Up @@ -483,7 +482,6 @@ impl PodBuilder {
) -> Result<&mut Self> {
let listener_reference = ListenerReference::ListenerName(listener_name.to_string());
let volume = ListenerOperatorVolumeSourceBuilder::new(&listener_reference, labels)
.context(ListenerVolumeSnafu { name: volume_name })?
.build_ephemeral()
.context(ListenerVolumeSnafu { name: volume_name })?;

Expand Down
10 changes: 4 additions & 6 deletions crates/stackable-operator/src/builder/pod/volume.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ pub enum ListenerOperatorVolumeSourceBuilderError {
/// &ListenerReference::ListenerClass("nodeport".into()),
/// &labels,
/// )
/// .unwrap()
/// .build_ephemeral()
/// .unwrap();
///
Expand All @@ -497,11 +496,11 @@ impl ListenerOperatorVolumeSourceBuilder {
pub fn new(
listener_reference: &ListenerReference,
labels: &Labels,
) -> Result<ListenerOperatorVolumeSourceBuilder, ListenerOperatorVolumeSourceBuilderError> {
Ok(Self {
) -> ListenerOperatorVolumeSourceBuilder {
Self {
listener_reference: listener_reference.to_owned(),
labels: labels.to_owned(),
})
}
}

fn build_spec(&self) -> PersistentVolumeClaimSpec {
Expand Down Expand Up @@ -636,8 +635,7 @@ mod tests {
let builder = ListenerOperatorVolumeSourceBuilder::new(
&ListenerReference::ListenerClass("public".into()),
&labels,
)
.unwrap();
);

let volume_source = builder.build_ephemeral().unwrap();

Expand Down