Skip to content

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 27, 2025

Description

We got feedback that some customers value breaking their cluster over giving operators RBAC permissions for CRDs :D
So WCGW?

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 27, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, definitely think this should be configurable.
It makes life easier for most, but there will be some who don't want the operator to have such access.

@sbernauer sbernauer requested a review from Techassi August 27, 2025 10:12
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor nit-pick.

@sbernauer sbernauer requested a review from Techassi August 27, 2025 12:54
@sbernauer sbernauer added this pull request to the merge queue Aug 27, 2025
Merged via the queue into main with commit 48f8aad Aug 27, 2025
8 checks passed
@sbernauer sbernauer deleted the feat/allow-disabling-crd-maintenance branch August 27, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants